On Mon, Jul 17, 2017 at 11:01:33AM -0700, Eric Anholt wrote: > Daniel Vetter <daniel.vetter@xxxxxxxx> writes: > > > CMA helpers are struct_mutex free, and so is the mxsfb itself. And > > that's the only valid reason for using gem_free_object. Please read > > the kerneldoc for this stuff :-) > > I'm sure all of these came from copy and paste, not the docs. That > said, the CMA docs currently say: > > * Drivers using the CMA helpers should set this as their > * &drm_driver.gem_free_object callback. > > If you drop the complaint about us reading the docs, the series is: I did double-check the docs for the two hooks to make sure they explain this, but forgot to check the one in the cma helpers. I'll follow-up with a patch to rectify that. > Reviewed-by: Eric Anholt <eric@xxxxxxxxxx> Thanks for your review. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
