Hi Sam, do you also have a Mesa patch showing how the new APIs will be used? Without seeing that, some minor comments below. On 01/07/17 04:25 AM, Samuel Li wrote: > > +//#include <errno.h> > +//#include <string.h> Remove these lines. > +#include "util/util_asic_id.h" Patch 1 adds the util directory to include paths, which would allow just #include "util_asic_id.h" Please consistently either use this, or don't add the util directory to the include path anywhere. > +int radeon_asic_id_initialize(void) > +{ > + int r = 0; > + pthread_mutex_lock(&asic_id_mutex); Put an empty line between declarations and statements. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel