On 24/05/17 13:46, Laurent Pinchart wrote: > Hi Tomi, > > On Wednesday 24 May 2017 13:37:48 Tomi Valkeinen wrote: >> On 24/05/17 13:28, Laurent Pinchart wrote: >>> On Thursday 04 May 2017 13:23:29 Tomi Valkeinen wrote: >>>> In this step we drop 'enum omap_color_mode', and use u32 instead. >>>> >>>> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@xxxxxx> >>> >>> I believe this should go before 12/16, otherwise you end up temporarily >>> storing DRM_FORMAT_* values in enum omap_color_mode variables. >> >> That's on purpose, I mention it in the previous patch. Do you see a >> problem with it? > > It's dirty :-) You had to silence a few warnings with explicit casts because > of that. > >> If I change the order, then I'd be going back and forth with u32 and >> enum omap_color_mode. > > If you first switch to u32, there's nothing wrong storing the enum > omap_color_mode value in a u32, and it will then be easy to transition to > DRM_FORMAT_*. True, I did that and the end result looks a bit cleaner. Thanks! Tomi
Attachment:
signature.asc
Description: OpenPGP digital signature
_______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
