Hi Tomi, Thank you for the patch. On Thursday 04 May 2017 13:23:29 Tomi Valkeinen wrote: > In this step we drop 'enum omap_color_mode', and use u32 instead. > > Signed-off-by: Tomi Valkeinen <tomi.valkeinen@xxxxxx> I believe this should go before 12/16, otherwise you end up temporarily storing DRM_FORMAT_* values in enum omap_color_mode variables. Apart from that, Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > --- > drivers/gpu/drm/omapdrm/dss/dispc.c | 48 +++++++++++++------------- > drivers/gpu/drm/omapdrm/dss/dss_features.c | 16 +++++----- > drivers/gpu/drm/omapdrm/dss/dss_features.h | 4 +-- > drivers/gpu/drm/omapdrm/dss/omapdss.h | 10 ++----- > drivers/gpu/drm/omapdrm/omap_drv.h | 2 +- > drivers/gpu/drm/omapdrm/omap_fb.c | 8 ++--- > 6 files changed, 42 insertions(+), 46 deletions(-) -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
