On Mon, May 22, 2017 at 09:56:00AM +0200, Daniel Vetter wrote: > On Fri, May 19, 2017 at 01:52:09AM +0100, Jose Abreu wrote: > > This series is a follow up from the discussion at [1]. We start by > > introducing crtc->mode_valid(), encoder->mode_valid() and > > bridge->mode_valid() callbacks which will be used in followup > > patches and also by cleaning the documentation a little bit. This > > patch is available at [2] and the series depends on it. > > > > We proceed by introducing new helpers to call this new callbacks > > at 1/10. > > > > At 2/10 a helper function is introduced that calls all mode_valid() > > from a set of bridges. > > > > Next, at 3/10 we modify the connector probe helper so that only modes > > which are supported by a given bridge+encoder+crtc combination are > > probbed. > > > > At 4/10 we call all the mode_valid() callbacks for a given pipeline, > > except the connector->mode_valid one, so that the mode is validated. > > This is done before calling mode_fixup(). > > > > Finally, from 5/10 to 10/10 we use the new callbacks in drivers that > > can implement it. > > > > [1] https://patchwork.kernel.org/patch/9702233/ > > [2] https://lists.freedesktop.org/archives/dri-devel/2017-May/141761.html > > > > Jose Abreu (10): > > drm: Add drm_{crtc/encoder/connector}_mode_valid() > > drm: Introduce drm_bridge_mode_valid() > > drm: Use new mode_valid() helpers in connector probe helper > > drm: Use mode_valid() in atomic modeset > > drm: arc: Use crtc->mode_valid() callback > > drm/bridge: analogix-anx78xx: Use bridge->mode_valid() callback > > drm/bridge/synopsys: dw-hdmi: Use bridge->mode_valid() callback > > drm/arm: malidp: Use crtc->mode_valid() callback > > drm/atmel-hlcdc: Use crtc->mode_valid() callback > > drm: vc4: Use crtc->mode_valid() and encoder->mode_valid() callbacks > > Looks all real nice, I think a bit more time to get acks/reviews/tested-by > for the driver conversions and I'll go and vacuum this all up. On that: You didn't cc driver maintainers on the driver conversion patches (not all are bridge drivers maintainer by Archit&co), without that they might miss it. Please remember to do that (you might need to resend to get their attention), scripts/get_maintainers.pl helps with that. Thanks, Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
