On Fri, May 19, 2017 at 01:52:09AM +0100, Jose Abreu wrote: > This series is a follow up from the discussion at [1]. We start by > introducing crtc->mode_valid(), encoder->mode_valid() and > bridge->mode_valid() callbacks which will be used in followup > patches and also by cleaning the documentation a little bit. This > patch is available at [2] and the series depends on it. > > We proceed by introducing new helpers to call this new callbacks > at 1/10. > > At 2/10 a helper function is introduced that calls all mode_valid() > from a set of bridges. > > Next, at 3/10 we modify the connector probe helper so that only modes > which are supported by a given bridge+encoder+crtc combination are > probbed. > > At 4/10 we call all the mode_valid() callbacks for a given pipeline, > except the connector->mode_valid one, so that the mode is validated. > This is done before calling mode_fixup(). > > Finally, from 5/10 to 10/10 we use the new callbacks in drivers that > can implement it. > > [1] https://patchwork.kernel.org/patch/9702233/ > [2] https://lists.freedesktop.org/archives/dri-devel/2017-May/141761.html > > Jose Abreu (10): > drm: Add drm_{crtc/encoder/connector}_mode_valid() > drm: Introduce drm_bridge_mode_valid() > drm: Use new mode_valid() helpers in connector probe helper > drm: Use mode_valid() in atomic modeset > drm: arc: Use crtc->mode_valid() callback > drm/bridge: analogix-anx78xx: Use bridge->mode_valid() callback > drm/bridge/synopsys: dw-hdmi: Use bridge->mode_valid() callback > drm/arm: malidp: Use crtc->mode_valid() callback > drm/atmel-hlcdc: Use crtc->mode_valid() callback > drm: vc4: Use crtc->mode_valid() and encoder->mode_valid() callbacks Looks all real nice, I think a bit more time to get acks/reviews/tested-by for the driver conversions and I'll go and vacuum this all up. Thanks a lot for doing this. -Daniel > > Cc: Carlos Palminha <palminha@xxxxxxxxxxxx> > Cc: Alexey Brodkin <abrodkin@xxxxxxxxxxxx> > Cc: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > Cc: Daniel Vetter <daniel.vetter@xxxxxxxx> > Cc: Dave Airlie <airlied@xxxxxxxx> > Cc: Andrzej Hajda <a.hajda@xxxxxxxxxxx> > Cc: Archit Taneja <architt@xxxxxxxxxxxxxx> > Cc: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > > drivers/gpu/drm/arc/arcpgu_crtc.c | 29 ++++--- > drivers/gpu/drm/arm/malidp_crtc.c | 11 ++- > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 9 +-- > drivers/gpu/drm/bridge/analogix-anx78xx.c | 13 ++- > drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 40 +++------- > drivers/gpu/drm/drm_atomic_helper.c | 76 +++++++++++++++++- > drivers/gpu/drm/drm_bridge.c | 33 ++++++++ > drivers/gpu/drm/drm_crtc_helper_internal.h | 13 +++ > drivers/gpu/drm/drm_probe_helper.c | 105 ++++++++++++++++++++++++- > drivers/gpu/drm/imx/dw_hdmi-imx.c | 4 +- > drivers/gpu/drm/meson/meson_dw_hdmi.c | 2 +- > drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 2 +- > drivers/gpu/drm/vc4/vc4_crtc.c | 13 ++- > drivers/gpu/drm/vc4/vc4_dpi.c | 13 ++- > include/drm/bridge/dw_hdmi.h | 2 +- > include/drm/drm_bridge.h | 2 + > 16 files changed, 280 insertions(+), 87 deletions(-) > > -- > 1.9.1 > > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
