Hi Tomi, On Monday 08 May 2017 17:35:50 Tomi Valkeinen wrote: > On 08/05/17 17:21, Laurent Pinchart wrote: > > On Thursday 27 Apr 2017 13:27:49 Tomi Valkeinen wrote: > >> We have been using DRM_MODE_CONNECTOR_Unknown for many of our outputs > >> because there has not been a proper connector type for them. > >> > >> We now have connector type for DPI so let's take it into use. At the > >> same time, add better connector types for the remaining outputs too. > >> > >> This patch sets the following outputs to use the following connector > >> types: > >> > >> DPI -> DPI > >> DBI -> DPI (MIPI DBI is very similar to DPI at the bus level) > > > > This looks OK to me. > > > >> SDI -> LVDS (SDI is a type of LVDS) > > > > If we're talking about this > > https://en.wikipedia.org/wiki/Serial_digital_interface SDI, it's not a > > type of LVDS at all. DRM_MODE_CONNECTOR_LVDS is interpreted as meaning > > that an LVDS display panel is attached to the device, and is likely not > > removable. I don't think it's a good match for SDI. We might need a new > > connector type. > > No, it's not that. It's Serial display interface. I think it's > FPDLink/FlatLink. Ah that makes more sense. Could you maybe mention that in the commit message ? > >> VENC -> SVIDEO (it could also be composite, but we don't have that > >> information here, so svideo should be quite good match) > > > > Do we have the information anywhere ? > > Yes, in the dts. At some point we should use that data, but I didn't > want to start digging the encoder/connector properties here. So we don't need to program the hardware differently for S-Video and Composite ? OK, in that case, with a few words about SDI in the commit message, Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
