Hi Tomi, Thank you for the patch. On Thursday 27 Apr 2017 13:27:49 Tomi Valkeinen wrote: > We have been using DRM_MODE_CONNECTOR_Unknown for many of our outputs > because there has not been a proper connector type for them. > > We now have connector type for DPI so let's take it into use. At the > same time, add better connector types for the remaining outputs too. > > This patch sets the following outputs to use the following connector > types: > > DPI -> DPI > DBI -> DPI (MIPI DBI is very similar to DPI at the bus level) This looks OK to me. > SDI -> LVDS (SDI is a type of LVDS) If we're talking about this https://en.wikipedia.org/wiki/Serial_digital_interface SDI, it's not a type of LVDS at all. DRM_MODE_CONNECTOR_LVDS is interpreted as meaning that an LVDS display panel is attached to the device, and is likely not removable. I don't think it's a good match for SDI. We might need a new connector type. > VENC -> SVIDEO (it could also be composite, but we don't have that > information here, so svideo should be quite good match) Do we have the information anywhere ? > Signed-off-by: Tomi Valkeinen <tomi.valkeinen@xxxxxx> > --- > drivers/gpu/drm/omapdrm/omap_drv.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/gpu/drm/omapdrm/omap_drv.c > b/drivers/gpu/drm/omapdrm/omap_drv.c index e1f47f0b3ccf..58c639e1e8e9 > 100644 > --- a/drivers/gpu/drm/omapdrm/omap_drv.c > +++ b/drivers/gpu/drm/omapdrm/omap_drv.c > @@ -214,6 +214,13 @@ static int get_connector_type(struct omap_dss_device > *dssdev) return DRM_MODE_CONNECTOR_DVID; > case OMAP_DISPLAY_TYPE_DSI: > return DRM_MODE_CONNECTOR_DSI; > + case OMAP_DISPLAY_TYPE_DPI: > + case OMAP_DISPLAY_TYPE_DBI: > + return DRM_MODE_CONNECTOR_DPI; > + case OMAP_DISPLAY_TYPE_VENC: > + return DRM_MODE_CONNECTOR_SVIDEO; > + case OMAP_DISPLAY_TYPE_SDI: > + return DRM_MODE_CONNECTOR_LVDS; > default: > return DRM_MODE_CONNECTOR_Unknown; > } -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
