Re: [PATCH 3/9] gpu: ipu-v3: add driver for Prefetch Resolve Engine

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2017-03-03 at 19:25 +0100, Lucas Stach wrote:
[...]
> > > +int ipu_pre_get(struct ipu_pre *pre)
> > > +{
> > > +	u32 val;
> > > +
> > > +	if (pre->in_use)
> > > +		return -EBUSY;
> > 
> > This could race for in_use ...
> 
> All the PRE/PRG configuration functions are thread unsafe, with the
> premise that they are only used during an atomic commit, [...]

Oh, okay. It would be nice to point this out in a comment.

regards
Philipp

_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux