Re: [PATCH 0/3] RFC: Common functions for GEM offset creation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 18 Jul 2011 19:20:56 -0500, Rob Clark <rob@xxxxxx> wrote:
> In the process of adding GEM support for OMAP DRM driver, I noticed that
> I was adding code for creating/freeing mmap offsets which was virtually
> identical to what was already duplicated in i915 and gma500 drivers.
> 
> Rather than duplicating the code a 3rd time, it seemed like a good idea
> to move it to the GEM core.
> 
> Note that I don't actually have a way to test psb or i915, but the
> changes seem straightforward enough.

My only concern is that for the common functions the mmap_offset to create
should be passed in a parameter, so that we could support more than one
mapping for an object.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel


[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux