Re: [PATCH] drm/amdgpu/gfx8: fix bugon.cocci warnings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jan 10, 2017 at 4:38 AM, Yu, Xiangliang <Xiangliang.Yu@xxxxxxx> wrote:
>>  Use BUG_ON instead of a if condition followed by BUG.
>>
>> Generated by: scripts/coccinelle/misc/bugon.cocci
>>
>> CC: Xiangliang Yu <Xiangliang.Yu@xxxxxxx>
>> Signed-off-by: Julia Lawall <julia.lawall@xxxxxxx>
>> Signed-off-by: Fengguang Wu <fengguang.wu@xxxxxxxxx>

Applied.  thanks!

Alex

>> ---
>>
>>  gfx_v8_0.c |    3 +--
>>  1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> --- a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
>> @@ -6623,8 +6623,7 @@ static void gfx_v8_0_ring_emit_fence_kiq
>>                                        u64 seq, unsigned int flags)
>>  {
>>       /* we only allocate 32bit for each seq wb address */
>> -     if (flags & AMDGPU_FENCE_FLAG_64BIT)
>> -             BUG();
>> +     BUG_ON(flags & AMDGPU_FENCE_FLAG_64BIT);
>>
>>       /* write fence seq to the "addr" */
>>       amdgpu_ring_write(ring, PACKET3(PACKET3_WRITE_DATA, 3));
>
> Reviewd-by: Xiangliang.Yu <Xiangliang.Yu@xxxxxxx>
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux