On Tue, Dec 27, 2016 at 11:49:25AM +0100, Daniel Vetter wrote: > This is the deprecated function for when you embedded the framebuffer > somewhere else (which breaks refcounting). But tegra is using > drm_framebuffer_remove and a free-standing fb, so this is rendundant. Nit: "Tegra", "redundant", "FB"? > > One caveat here is that the failur path in the init code still "failure" > manually cleaned up the fb. I presume that was an oversigth and "oversight" > changed it over to drm_framebuffer_remove too. > > Cc: Thierry Reding <thierry.reding@xxxxxxxxx> > Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxxx> > --- > drivers/gpu/drm/tegra/fb.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) Yes, drm_framebuffer_remove() ends up calling tegra_fb_destroy(), which is really what we need here, so: Acked-by: Thierry Reding <treding@xxxxxxxxxx>
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
