On 2016-12-28 19:53, Gabriel Krisman Bertazi wrote: > Fabio Estevam <festevam@xxxxxxxxx> writes: > >> On Wed, Dec 28, 2016 at 4:38 PM, Gabriel Krisman Bertazi >> <krisman@xxxxxxxxxxxxxxx> wrote: >> >>> This leaks tcon if clk_prepare_enable fails. >> >> No, it does not as tcon is allocated via devm_kzalloc(). > > Agreed. But I think devm_kzalloc() only drops the memory once the > device is removed, which is not the case here, since failing > fsl_tcon_init is not fatal and the initialization continues in this > case. That is probably true, but does it matter? I guess it is anyway an unlikely case, so why bother? -- Stefan _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
