Fabio Estevam <festevam@xxxxxxxxx> writes: > On Wed, Dec 28, 2016 at 4:38 PM, Gabriel Krisman Bertazi > <krisman@xxxxxxxxxxxxxxx> wrote: > >> This leaks tcon if clk_prepare_enable fails. > > No, it does not as tcon is allocated via devm_kzalloc(). Agreed. But I think devm_kzalloc() only drops the memory once the device is removed, which is not the case here, since failing fsl_tcon_init is not fatal and the initialization continues in this case. -- Gabriel Krisman Bertazi _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel