On 12/07/2016 09:53 PM, Dave Airlie wrote: >>>> Yeah, already done. >>> >>> Just tried to build drm-next/mxsfb I get: >>> >>> drivers/built-in.o: In function `mxsfb_probe': >>> core.c:(.text+0x9ce9c): undefined reference to `drm_panel_attach' >>> core.c:(.text+0x9cff0): undefined reference to `drm_panel_detach' >>> drivers/built-in.o: In function `mxsfb_panel_connector_destroy': >>> core.c:(.text+0x9d614): undefined reference to `drm_panel_detach' >>> drivers/built-in.o: In function `mxsfb_create_output': >>> core.c:(.text+0x9d68c): undefined reference to `of_drm_find_panel' >>> make: *** [Makefile:962: vmlinux] Error 1 >>> >>> I guess there is a select DRM_PANEL missing. >> >> Aw snap, I think imx_v6_v7_defconfig selects DRM_PANEL already, so this >> was never caught. Which is the path of least resistance, additional >> patch or respinning the whole PR ? > > Just send patch to list and then a pull request for it. > Patch is out, sorry for the hassle. -- Best regards, Marek Vasut _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel