On 12/07/2016 08:22 PM, Stefan Agner wrote: > On 2016-12-06 04:36, Marek Vasut wrote: >> On 12/06/2016 08:53 AM, Daniel Vetter wrote: >>> On Tue, Dec 06, 2016 at 11:08:06AM +1000, Dave Airlie wrote: >>>> On 2 December 2016 at 04:02, Marek Vasut <marex@xxxxxxx> wrote: >>>>> Hi, >>>>> >>>>> as asked by Daniel, I collected the MXSFB DT Acks and the driver and >>>>> wrapped it into PR (below). >>>> >>>> Hi Marek >>>> >>>> this isn't pullable as-is as it seems to be based on -next tree or something. >>>> >>>> Please create pull requests based on a Linus or drm-next base, >>> >>> Please base on drm-next, to make sure you can (and do) use latest drm code >>> with all the latest refactorings applied. >> >> Yeah, already done. > > Just tried to build drm-next/mxsfb I get: > > drivers/built-in.o: In function `mxsfb_probe': > core.c:(.text+0x9ce9c): undefined reference to `drm_panel_attach' > core.c:(.text+0x9cff0): undefined reference to `drm_panel_detach' > drivers/built-in.o: In function `mxsfb_panel_connector_destroy': > core.c:(.text+0x9d614): undefined reference to `drm_panel_detach' > drivers/built-in.o: In function `mxsfb_create_output': > core.c:(.text+0x9d68c): undefined reference to `of_drm_find_panel' > make: *** [Makefile:962: vmlinux] Error 1 > > I guess there is a select DRM_PANEL missing. Aw snap, I think imx_v6_v7_defconfig selects DRM_PANEL already, so this was never caught. Which is the path of least resistance, additional patch or respinning the whole PR ? -- Best regards, Marek Vasut _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
