On 31 October 2016 at 17:44, Rob Clark <robdclark@xxxxxxxxx> wrote: > On Mon, Oct 31, 2016 at 1:15 PM, Emil Velikov <emil.l.velikov@xxxxxxxxx> wrote: >> On 31 October 2016 at 16:39, Rob Clark <robdclark@xxxxxxxxx> wrote: >>> On Mon, Oct 31, 2016 at 11:25 AM, Emil Velikov <emil.l.velikov@xxxxxxxxx> wrote: >>>> On 31 October 2016 at 13:44, Rob Clark <robdclark@xxxxxxxxx> wrote: >>>>> From: Rob Clark <robclark@xxxxxxxxxxxxxxx> >>>>> >>>>> Rather than cut/pasting these couple ioctl wrappers everywhere, just >>>>> stuff them as static-inline into a header. >>>>> >>>>> Signed-off-by: Rob Clark <robclark@xxxxxxxxxxxxxxx> >>>>> --- >>>>> This is probably mostly used from mesa, but some drivers, test apps, etc >>>>> may also want to use it from libdrm. >>>>> >>>> It makes sense imho. To avoid fun experiences we want the header >>>> synced in an identical manner (make headers_install) to the >>>> include/drm ones. One might as well move it there, so make its "more" >>>> obvious. >>>> >>> >>> hmm, not sure I understand, but '#include <libsync.h>' seems to work >>> in either case.. >>> >> The file is from the kernel UAPI, correct ? If so store it alongside >> the other UAPI ones include/drm/ and import `make headers_install' >> (see git log -- include/drm for examples). > > no, it copy/pastes a few lines from uabi/linux/sync_file.h just to > avoid a dependency on kernel headers. I guess I *could* copy > sync_file.h into libdrm, but it isn't really a drm uabi header, so I > didn't want to do that > #include <linux/sync_file.h> and drop the copy/pasta ? The latter will come to bite us sooner or later. Just for information: memset should work everywhere. Everything else will produce a warning as you move through GCC versions. Thanks Emil _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
