On Fri, Sep 30, 2016 at 7:52 AM, Christian König <christian.koenig@xxxxxxx> wrote: > This one and patch #3 are Reviewed-by: Christian König > <christian.koenig@xxxxxxx>. > Applied 1 and 3, thanks! Alex > Where is patch #2? That never made it into my inbox. > > Regards, > Christian. > > > Am 30.09.2016 um 10:13 schrieb Baoyou Xie: >> >> We get a few warnings when building kernel with W=1: >> drivers/gpu/drm/radeon/radeon_clocks.c:35:10: warning: no previous >> prototype for 'radeon_legacy_get_engine_clock' [-Wmissing-prototypes] >> drivers/gpu/drm/radeon/atombios_encoders.c:75:1: warning: no previous >> prototype for 'atombios_get_backlight_level' [-Wmissing-prototypes] >> drivers/gpu/drm/radeon/r600_cs.c:2268:5: warning: no previous prototype >> for 'r600_cs_parse' [-Wmissing-prototypes] >> drivers/gpu/drm/radeon/evergreen_cs.c:2671:5: warning: no previous >> prototype for 'evergreen_cs_parse' [-Wmissing-prototypes] >> .... >> >> In fact, these functions are declared >> in drivers/gpu/drm/radeon/radeon_asic.h, >> so this patch adds missing header dependencies. >> >> Signed-off-by: Baoyou Xie <baoyou.xie@xxxxxxxxxx> >> --- >> drivers/gpu/drm/radeon/atombios_encoders.c | 1 + >> drivers/gpu/drm/radeon/evergreen_cs.c | 1 + >> drivers/gpu/drm/radeon/r600_cs.c | 1 + >> drivers/gpu/drm/radeon/radeon_atombios.c | 1 + >> drivers/gpu/drm/radeon/radeon_clocks.c | 1 + >> drivers/gpu/drm/radeon/radeon_legacy_encoders.c | 1 + >> 6 files changed, 6 insertions(+) >> >> diff --git a/drivers/gpu/drm/radeon/atombios_encoders.c >> b/drivers/gpu/drm/radeon/atombios_encoders.c >> index 56bb758..fa4f8f0 100644 >> --- a/drivers/gpu/drm/radeon/atombios_encoders.c >> +++ b/drivers/gpu/drm/radeon/atombios_encoders.c >> @@ -28,6 +28,7 @@ >> #include <drm/radeon_drm.h> >> #include "radeon.h" >> #include "radeon_audio.h" >> +#include "radeon_asic.h" >> #include "atom.h" >> #include <linux/backlight.h> >> diff --git a/drivers/gpu/drm/radeon/evergreen_cs.c >> b/drivers/gpu/drm/radeon/evergreen_cs.c >> index d960d39..f8b0509 100644 >> --- a/drivers/gpu/drm/radeon/evergreen_cs.c >> +++ b/drivers/gpu/drm/radeon/evergreen_cs.c >> @@ -27,6 +27,7 @@ >> */ >> #include <drm/drmP.h> >> #include "radeon.h" >> +#include "radeon_asic.h" >> #include "evergreend.h" >> #include "evergreen_reg_safe.h" >> #include "cayman_reg_safe.h" >> diff --git a/drivers/gpu/drm/radeon/r600_cs.c >> b/drivers/gpu/drm/radeon/r600_cs.c >> index b69c8de..595a197 100644 >> --- a/drivers/gpu/drm/radeon/r600_cs.c >> +++ b/drivers/gpu/drm/radeon/r600_cs.c >> @@ -28,6 +28,7 @@ >> #include <linux/kernel.h> >> #include <drm/drmP.h> >> #include "radeon.h" >> +#include "radeon_asic.h" >> #include "r600d.h" >> #include "r600_reg_safe.h" >> diff --git a/drivers/gpu/drm/radeon/radeon_atombios.c >> b/drivers/gpu/drm/radeon/radeon_atombios.c >> index 5df3ec7..4134759 100644 >> --- a/drivers/gpu/drm/radeon/radeon_atombios.c >> +++ b/drivers/gpu/drm/radeon/radeon_atombios.c >> @@ -29,6 +29,7 @@ >> #include "atom.h" >> #include "atom-bits.h" >> +#include "radeon_asic.h" >> extern void >> radeon_add_atom_encoder(struct drm_device *dev, uint32_t encoder_enum, >> diff --git a/drivers/gpu/drm/radeon/radeon_clocks.c >> b/drivers/gpu/drm/radeon/radeon_clocks.c >> index 38e396d..c1135fe 100644 >> --- a/drivers/gpu/drm/radeon/radeon_clocks.c >> +++ b/drivers/gpu/drm/radeon/radeon_clocks.c >> @@ -29,6 +29,7 @@ >> #include <drm/radeon_drm.h> >> #include "radeon_reg.h" >> #include "radeon.h" >> +#include "radeon_asic.h" >> #include "atom.h" >> /* 10 khz */ >> diff --git a/drivers/gpu/drm/radeon/radeon_legacy_encoders.c >> b/drivers/gpu/drm/radeon/radeon_legacy_encoders.c >> index 868c3ba..222a1fa 100644 >> --- a/drivers/gpu/drm/radeon/radeon_legacy_encoders.c >> +++ b/drivers/gpu/drm/radeon/radeon_legacy_encoders.c >> @@ -27,6 +27,7 @@ >> #include <drm/drm_crtc_helper.h> >> #include <drm/radeon_drm.h> >> #include "radeon.h" >> +#include "radeon_asic.h" >> #include "atom.h" >> #include <linux/backlight.h> >> #ifdef CONFIG_PMAC_BACKLIGHT > > > > _______________________________________________ > dri-devel mailing list > dri-devel@xxxxxxxxxxxxxxxxxxxxx > https://lists.freedesktop.org/mailman/listinfo/dri-devel _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
