On Thu, Jun 9, 2011 at 12:36 PM, Dave Airlie wrote: > On Thu, 2011-06-09 at 09:11 +0100, Alan Cox wrote: >> On Thu, 9 Jun 2011 03:10:03 +0200 >> Patrik Jakobsson wrote: >> >> > Hi Alan >> > >> > Just a thought. Shouldn't we use the DRM macros for printing debug info? >> >> Linux has perfectly good printing functions and using them means we can >> use dev_dbg() which supports things like nice runtime switching. > > You mean like the drm debug functions runtime switching? that predated > the kernel ones and nobody ever ported :-) > > Though if psb wants to be different to other drm drivers it can lead the > way, though it'll be a total nightmare for all the people who follow > documentation on how to debug drm drivers using drm.debug=1,2,4,8. for > various code paths. Yes, my concern was about drm.debug and use of all the DRM portability stuff (like using DRM_IRQ_HANDLED instead of IRQ_HANDLED, etc...) The portability might not be important at this point but I just wanted to raise the question so I know what is right / wrong. Alan, I've been working on the output code but think I've reached a dead end. I'm up to 20000 lines of changes and it's just a big mess. I'm gonna go for slowly fixing up the current code instead. I also got my hands on a laptop with a gma500 so I can test that my changes doesn't break LVDS. Stay tuned. Thanks _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
