On Sun, 2016-08-21 at 20:45 +0200, Heinrich Schuchardt wrote: > On 08/21/2016 08:29 PM, Joe Perches wrote: > > On Sun, 2016-08-21 at 20:06 +0200, Heinrich Schuchardt wrote: > > > In an if block for (running == 0) running cannot be non-zero. > > This code could also be better unindented by one level > > (all of the block would fit 80 columns) by changing: > > > > if (running == 0) { > > [code...] > > } > > > > return 0; > > > > to: > > > > if (running) > > return 0; > > > > [code...] > > > > return 0; > Should I revise my patch? > Or should this be an additional patch? If you want to do it, an additional patch is probably best. _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel