On Sun, 2016-08-21 at 20:39 +0200, Heinrich Schuchardt wrote: > Components m1, m2, p2, dot, vco of variable clock should be > initialized to avoid bytes from the kernel stack to be > exposed. How was this found? visual code inspection? And isn't this true for mrst_lvds_find_best_pll as well? > a@@ -138,6 +138,7 @@ static bool mrst_sdvo_find_best_pll(const struct gma_limit_t *limit, > u32 target_vco, actual_freq; > s32 freq_error, min_error = 100000; > > + memset(clock, 0, sizeof(struct gma_clock_t)); > memset(best_clock, 0, sizeof(*best_clock)); > > for (clock.m = limit->m.min; clock.m <= limit->m.max; clock.m++) { _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel