On Tue, Jul 19, 2016 at 10:14:07AM +0200, Geert Uytterhoeven wrote: > On Mon, Jul 18, 2016 at 4:45 PM, Daniel Vetter <daniel@xxxxxxxx> wrote: > > On Mon, Jul 18, 2016 at 04:10:36PM +0200, SF Markus Elfring wrote: > >> From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> > >> Date: Mon, 18 Jul 2016 16:06:18 +0200 > >> > >> The ttm_tt_destroy() function tests whether its argument is NULL > >> and then returns immediately. Thus the test around the call is not needed. > >> > >> This issue was detected by using the Coccinelle software. > >> > >> Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> > > > > When resending pls describe what changed (and why). Also I'd still like > > that smatch included in the commit message. > > A similar change was made in drm-next, causing a merge conflict > between the drm-next and drm-misc trees. > > commit 4279cb1423d96e53b6b98ae9f2b41003b013a31f > Author: Christian König <christian.koenig@xxxxxxx> > Date: Mon Jun 6 10:17:51 2016 +0200 > > drm/ttm: remove NULL checks when calling ttm_tt_destroy > > The function is a no-op with a NULL pointer. > > Reviewed-by: Alex Deucher <alexander.deucher@xxxxxxx> > Signed-off-by: Christian König <christian.koenig@xxxxxxx> > Signed-off-by: Alex Deucher <alexander.deucher@xxxxxxx> Yeah, realized that too but then drm-misc is a non-rebasing tree now, so can't take this out. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
