Re: [PATCH v8 4/4] drm/panel: Add JDI LT070ME05000 WUXGA DSI Panel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Fri, Jul 15, 2016 at 2:48 AM, Emil Velikov <emil.l.velikov@xxxxxxxxx> wrote:
On 13 July 2016 at 19:58, John Stultz <john.stultz@xxxxxxxxxx> wrote:
> On Wed, Jul 13, 2016 at 9:44 AM, Vinay Simha BN <simhavcs@xxxxxxxxx> wrote:
>> Add support for the JDI LT070ME05000 WUXGA DSI panel used in
>> Nexus 7 2013 devices.
>>
>> Programming sequence for the panel is was originally found in the
>> android-msm-flo-3.4-lollipop-release branch from:
>>     https://android.googlesource.com/kernel/msm.git
>>
>> And video mode setting is from dsi-panel-jdi-dualmipi1-video.dtsi
>> file in:
>>     git://codeaurora.org/kernel/msm-3.10.git  LNX.LA.3.6_rb1.27
>>
>> Cc: Archit Taneja <archit.taneja@xxxxxxxxx>
>> Cc: Rob Clark <robdclark@xxxxxxxxx>
>> Cc: Sumit Semwal <sumit.semwal@xxxxxxxxxx>
>> Cc: John Stultz <john.stultz@xxxxxxxxxx>
>> Cc: Emil Velikov <emil.l.velikov@xxxxxxxxx>
>> Cc: Thierry Reding <thierry.reding@xxxxxxxxx>
>> Cc: David Airlie <airlied@xxxxxxxx>
>> Signed-off-by: Sumit Semwal <sumit.semwal@xxxxxxxxxx>
>> Signed-off-by: John Stultz <john.stultz@xxxxxxxxxx>
>> Signed-off-by: Vinay Simha BN <simhavcs@xxxxxxxxx>
>
> Just fyi, I've re-integrated this patch set into my flo-WIP branch and
> its working well.
>
> I dunno if its of any use, but:
> Tested-by: John Stultz <john.stultz@xxxxxxxxxx>
>
It always is. Thank you!

Vinay, thanks for the patience and I hope you grok the reason behind
the requested changes.
yes.

premature returns should be avoided. it leads to the caller failure, intermediate funcs also will not get executed (gpios, regulator disable).
In this case even the dsi fails, it should be panel(dsi write) failures rather than the bridge/interface. 

The patch is
Reviewed-by: Emil Velikov <emil.l.velikov@xxxxxxxxx>

Regards,
Emil



--
Regards,

Vinay Simha.B.N.

_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux