Re: [PATCH v2 3/4] drm/dsi: Implement dcs set/get display brightness

[Vinay Simha <simhavcs@xxxxxxxxx>]

yes, it is wrong.

it supposed to be 

if(err <= 0) {

          if(err == 0)

will resend a modified version

On Fri, Jul 15, 2016 at 2:50 AM, Emil Velikov <emil.l.velikov@xxxxxxxxx> wrote:

On 13 July 2016 at 17:44, Vinay Simha BN <simhavcs@xxxxxxxxx> wrote:

> +int mipi_dsi_dcs_get_display_brightness(struct mipi_dsi_device *dsi,
> +                                       u16 *brightness)
> +{
> +       ssize_t err;
> +
> +       err = mipi_dsi_dcs_read(dsi, MIPI_DCS_GET_DISPLAY_BRIGHTNESS,
> +                               brightness, sizeof(*brightness));
> +       if (err < 0) {
> +               if (err == 0)
Something looks fishy here. This can never be true, can it ?

 -Emil

--

Regards,

Vinay Simha.B.N.

_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel