On Mon, Jun 13, 2016 at 11:20 AM, Gerd Hoffmann <kraxel@xxxxxxxxxx> wrote: > On Fr, 2016-06-10 at 17:20 +0200, Daniel Vetter wrote: >> On Fri, Jun 10, 2016 at 12:07:53AM +0200, Daniel Vetter wrote: >> > Now that the core helpers support nonblocking atomic commits there's >> > no need to invent that wheel separately (instead of fixing the bug in >> > the atomic implementation of virtio, as it should have been done!). >> > >> > v2: Rebased on top of >> > >> > commit e7cf0963f816fa44190caaf51aeffaa614c340c6 >> > Author: Gerd Hoffmann <kraxel@xxxxxxxxxx> >> > Date: Tue May 31 08:50:47 2016 +0200 >> > >> > virtio-gpu: add atomic_commit function >> > >> > Cc: Gerd Hoffmann <kraxel@xxxxxxxxxx> >> > Tested-by: Gerd Hoffmann <kraxel@xxxxxxxxxx> (v1) >> > Reviewed-by: Gerd Hoffmann <kraxel@xxxxxxxxxx> (v1) >> > Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxxx> >> >> Gerd, can you pls retest? I think due to your change in the above >> referenced commit to switch to active_only=true in commit_planes() this is >> now broken. > > Yes, probably it'll break things. > > Any branch I can test? Your "stuff" branch seems to not yet have the > commit above. > > I guess virtio-gpu should switch over to override .atomic_commit_tail > instead of .atomic_commit? See v2 that I've sent out - it contains these changes already. Patch applies on top of topic/drm-misc, but I'll be pushing out a new version of stuff asap. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
