Rob, On Fri, Jun 10, 2016 at 6:42 AM, Rob Herring <robh@xxxxxxxxxx> wrote: > On Wed, Jun 08, 2016 at 07:52:45PM +0800, Yakir Yang wrote: >> The Sharp LQ123P1JX31 is an 12.3" 2400x1600 TFT-LCD panel >> connected using eDP interfaces. >> >> Signed-off-by: Yakir Yang <ykk@xxxxxxxxxxxxxx> >> --- >> Changes in v2: >> - Add dt-bindings of Sharp LQ123P1JX31 panel in v2 >> >> .../devicetree/bindings/display/panel/sharp,lq123p1jx31.txt | 7 +++++++ >> 1 file changed, 7 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/display/panel/sharp,lq123p1jx31.txt >> >> diff --git a/Documentation/devicetree/bindings/display/panel/sharp,lq123p1jx31.txt b/Documentation/devicetree/bindings/display/panel/sharp,lq123p1jx31.txt >> new file mode 100644 >> index 0000000..81938c0 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/display/panel/sharp,lq123p1jx31.txt >> @@ -0,0 +1,7 @@ >> +Sharp 12.3" (2400x1600 pixels) TFT LCD panel >> + >> +Required properties: >> +- compatible: should be "sharp,lq123p1jx31," > ^ > Need to drop the comma. Thanks for catching! > No regulators or resets or pwms? Could be more explicit I guess, but Yakir does say: > This binding is compatible with the simple-panel binding, which is specified > in simple-panel.txt in this directory. In that document it shows: Required properties: - power-supply: regulator to provide the supply voltage Optional properties: - ddc-i2c-bus: phandle of an I2C controller used for DDC EDID probing - enable-gpios: GPIO pin to enable or disable the panel - backlight: phandle of the backlight device attached to the panel In general Yakir's bindings document match a huge chunk of the current existing bindings. Do this: cd Documentation/devicetree/bindings/display/panel grep -C20 "This binding is compatible with the simple-panel" * You'll find a huge chunk of files which are rather formulaic. It might make sense to just have one file and a list of panels which are simple panels? -Doug _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
