On 10 June 2016 at 00:42, Eric Anholt <eric@xxxxxxxxxx> wrote: > Rob Herring <robh@xxxxxxxxxx> writes: > >> Ioctls generally have DRM_AUTH and DRM_RENDER_ALLOW set to restrict them >> to authorized clients and render nodes. Without this, access from render >> nodes fails. > > We've already got a fix to add RENDER_ALLOW submitted in the latest > drm-vc4-fixes. There's no reason to require auth on this > implementation, though. > Not 100% sure but I think you do. At least every other driver does... Why: I'm thinking that without DRM_AUTH one will be able to open the card# node and issue the said IOCTLs even if the client is not authenticated. Which, obviously isn't a huge deal, but doesn't sound right. Then again, my knowledge of vc4 is virtually non-existent, so there might be something special happening here ? Regards, Emil _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
