Hi Javier, 2016년 05월 31일 07:58에 Javier Martinez Canillas 이(가) 쓴 글: > Hello Inki, > > On 04/05/2016 04:27 AM, Inki Dae wrote: >> This patch adds HW trigger support on i80 mode. >> >> Until now, Exynos DRM only supported SW trigger which was set >> SWTRGCMD bit of TRIGCON register by CPU to transfer scanout >> buffer to Display bus device or panel. >> >> With this patch, the transmission to Display bus device or >> panel will be initiated by FIMD controller. >> >> Signed-off-by: Inki Dae <inki.dae@xxxxxxxxxxx> >> --- > > There is a regression for the Exynos5800 Peach Pi Chromebook display due > this patch. The display is blank and I noticed that it only happens when > HW start trigger is enabled, but works with SW trigger (as it was before). Posted below pathch, [PATCH] drm/exynos: fimd: fix trigger mode change regression Can you test it again with the patch? I have no HW to test it. :( Thanks, Inki Dae > > So for example with the following diff on top of v4.7-rc1, display works > again. Do you have any hints about what could be the issue? > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c > index 0444d7fc400d..8c62830e9514 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c > +++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c > @@ -171,7 +171,7 @@ static struct fimd_driver_data exynos5420_fimd_driver_data = { > .lcdblk_vt_shift = 24, > .lcdblk_bypass_shift = 15, > .lcdblk_mic_bypass_shift = 11, > - .trg_type = I80_HW_TRG, > .has_shadowcon = 1, > .has_vidoutcon = 1, > .has_vtsel = 1, > > Best regards, > _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel