On Tue, 17 May 2016, Francois Tigeot wrote:
On the other hand, the non-Linux code path really is unused. I didn't want
to be too intrusive in my patch but it's probably best to just remove it.
There is more to this world than Linux and BSD, there's Solaris as
well. Even though they tend to be very quiet ;-)
I was hoping to change that a little, but there is still a fair amount
of work going on in enough areas to keep us busy and not very talkative
(I try to scan this list regularly, though).
Right. I forgot about it since the Solaris-derived source code I have easy
access to is illumos-gate and its drm.h hasn't been updated since 2009.
If you are interested in the primary Solaris source, you will really
want to looking at:
https://java.net/projects/solaris-x11/sources/x-s12-clone/show/open-src/kernel
On thing that you will notice is that this version duplicates headers
between libdrm and the kernel driver. The next version (a week or so)
will have updated this to consume libdrm headers.
TL;DR: Please don't diverge userspace vs kernel drm headers. Just beat
it in shape so that it works in both cases (most likely the 'else'
one).
Hopefully ^^ does not sound to hard to achieve and/or demanding ?
They are divergent by design :-/
Making the Linux headers public and removing the #else path in libdrm's
drm.h could be the right thing to do. I'll keep thinking about it...
Removing the #else path will cause Solaris compiles to fail as it does
consume that side of the conditional (though, as we patch this file and
don't use it as is, it would be trivial to add it or any other
Solaris-specific requirements back in).
From a Solaris perspective, I don't see how this file can ever -not-
have conditional compile statements or be patched to support Solaris, as
there are sufficient differences requiring at least minor changes.
P.S. Perhaps we should spend an hour or so over the next XDC trying to
flush any remaining differences/patches in the graphics stack ? Not
sure how many BSD/Solaris people will be around though.
I'm afraid there won't be many *BSD people around. This year, the XDC and
EuroBSDCon conferences fall on the same week-end :-(
I'm not sure which one I will be attending to at this point.
Thanks Emil,
--
Francois Tigeot
Not sure yet if I will be attending either. But would happily provide
any input on this either in person (if I am there), or via email.
Cheers!
---- Randy
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
