Re: [PATCH] drm: Fix compilation on systems that don't provide O_CLOEXEC

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 20 April 2016 at 16:25, Stefan Dirsch <sndirsch@xxxxxxx> wrote:
> On Wed, Apr 20, 2016 at 04:47:20PM +0200, Daniel Vetter wrote:
>> On Wed, Apr 20, 2016 at 4:39 PM, Stefan Dirsch <sndirsch@xxxxxxx> wrote:
>> > Patch suggestion by Thomas Klausner. See also
>> > http://mail-index.netbsd.org/pkgsrc-changes/2012/08/13/msg076887.html
>> >
>> > Signed-off-by: Stefan Dirsch <sndirsch@xxxxxxx>
>>
>> Fix your OS to have O_CLOEXEC semantics I think is what should happen
>> here. It's an obvious race in multi-threaded apps, and you need a fix
>> for it anyway.
>> -Daniel
>
> Indeed I figured out the patch is no longer needed and finally removed it. ;-)
>
No problem Stefan and thanks for starting to get the Suse patches upstreamed.

A few friendly suggestions - please correctly the patch author (if not
yourself) and don't add their s-o-b unless they have done/agreed so.

Thanks,
Emil

P.S. [Note to self~ish~] Perhaps it's time we unconditionally use
O_CLOEXEC in mesa...
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux