On Tue, Mar 15, 2016 at 10:23:04AM +0100, Daniel Vetter wrote: > On Tue, Mar 15, 2016 at 09:32:22AM +0100, Thomas Hellstrom wrote: > > On 03/15/2016 09:14 AM, Daniel Vetter wrote: > > > On Tue, Mar 15, 2016 at 08:30:03AM +0100, Thomas Hellstrom wrote: > > >> X re-export these values as 32-bit, so they end up as -1. > > >> > > >> Signed-off-by: Thomas Hellstrom <thellstrom@xxxxxxxxxx> > > > Imo that's a bug in X, and X should clamp the range itself. Not the > > > kernel. Prop abi is pretty consistent that its all 64bit values. > > > -Daniel > > > > True. Otoh, we can't really change old X servers to support this, and > > the range doesn't really need to be that large. > > (It's already restricted to 32 bits and restricting it to 31 bits > > doesn't make a big difference). > > Well if current X is fixed (we don't want to repeat this fun for other > props) then I'm ok with this, with a comment. Just want to avoid working > around bugs in other software for no good reason. And S32_MAX for readability please, I can't count rows of fffffff ;-) -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
