On Tue, Mar 15, 2016 at 09:32:22AM +0100, Thomas Hellstrom wrote: > On 03/15/2016 09:14 AM, Daniel Vetter wrote: > > On Tue, Mar 15, 2016 at 08:30:03AM +0100, Thomas Hellstrom wrote: > >> X re-export these values as 32-bit, so they end up as -1. > >> > >> Signed-off-by: Thomas Hellstrom <thellstrom@xxxxxxxxxx> > > Imo that's a bug in X, and X should clamp the range itself. Not the > > kernel. Prop abi is pretty consistent that its all 64bit values. > > -Daniel > > True. Otoh, we can't really change old X servers to support this, and > the range doesn't really need to be that large. > (It's already restricted to 32 bits and restricting it to 31 bits > doesn't make a big difference). Well if current X is fixed (we don't want to repeat this fun for other props) then I'm ok with this, with a comment. Just want to avoid working around bugs in other software for no good reason. -Daniel > > /Thomas > > > > > >> --- > >> drivers/gpu/drm/drm_crtc.c | 4 ++-- > >> 1 file changed, 2 insertions(+), 2 deletions(-) > >> > >> diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c > >> index 8451400..a27b2e0 100644 > >> --- a/drivers/gpu/drm/drm_crtc.c > >> +++ b/drivers/gpu/drm/drm_crtc.c > >> @@ -1789,10 +1789,10 @@ int drm_mode_create_suggested_offset_properties(struct drm_device *dev) > >> return 0; > >> > >> dev->mode_config.suggested_x_property = > >> - drm_property_create_range(dev, DRM_MODE_PROP_IMMUTABLE, "suggested X", 0, 0xffffffff); > >> + drm_property_create_range(dev, DRM_MODE_PROP_IMMUTABLE, "suggested X", 0, 0x7fffffff); > >> > >> dev->mode_config.suggested_y_property = > >> - drm_property_create_range(dev, DRM_MODE_PROP_IMMUTABLE, "suggested Y", 0, 0xffffffff); > >> + drm_property_create_range(dev, DRM_MODE_PROP_IMMUTABLE, "suggested Y", 0, 0x7fffffff); > >> > >> if (dev->mode_config.suggested_x_property == NULL || > >> dev->mode_config.suggested_y_property == NULL) > >> -- > >> 2.5.0 > >> > >> > >> _______________________________________________ > >> dri-devel mailing list > >> dri-devel@xxxxxxxxxxxxxxxxxxxxx > >> https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.freedesktop.org_mailman_listinfo_dri-2Ddevel&d=BQIBAg&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=vpukPkBtpoNQp2IUKuFviOmPNYWVKmen3Jeeu55zmEA&m=tk1_0FQoUlZD2ybivU9sASZgACk0FHEeIHWhp07U3Z0&s=2G9Zzwff6weMglpvwYsaZF9e1ginaxM62nYFBU0x2Bs&e= > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
