Hi Tomi, On Thursday 25 February 2016 17:56:57 Tomi Valkeinen wrote: > On 24/02/16 01:02, Laurent Pinchart wrote: > > On Friday 19 February 2016 11:48:05 Tomi Valkeinen wrote: > >> The DSS hardware uses the same ROW_INC value for both Y and UV planes > >> for NV12 format. This means that the pitches of the Y and UV planes have > >> to match. omapdrm doesn't check this at the moment, and this can lead > >> into a broken NV12 fb on the screen. > >> > >> This patch adds the check. > >> > >> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@xxxxxx> > > > > Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > > > > We can probably simplify the implementation further as most of the checks > > in the loop apply to the first place only. Would you like me to give it a > > go ? > > "place" is plane? Yes, sorry. > I don't quite understand what you mean. The checks apply to all planes. My point is that if you add a check to ensure that the pitch is identical in all planes, the other tests on the pitch don't have to be repeated for every plane. -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
