Re: [PATCH 30/33] drm/omap: verify that fb plane pitches are the same

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 24/02/16 01:02, Laurent Pinchart wrote:
> Hi Tomi,
> 
> Thank you for the patch.
> 
> On Friday 19 February 2016 11:48:05 Tomi Valkeinen wrote:
>> The DSS hardware uses the same ROW_INC value for both Y and UV planes
>> for NV12 format. This means that the pitches of the Y and UV planes have
>> to match. omapdrm doesn't check this at the moment, and this can lead
>> into a broken NV12 fb on the screen.
>>
>> This patch adds the check.
>>
>> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@xxxxxx>
> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> 
> We can probably simplify the implementation further as most of the checks in 
> the loop apply to the first place only. Would you like me to give it a go ?

"place" is plane? I don't quite understand what you mean. The checks
apply to all planes.

 Tomi

Attachment: signature.asc
Description: OpenPGP digital signature

_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux