On Thu 06-01-11 22:08:46, Alex Riesen wrote: > On Thu, Jan 6, 2011 at 21:55, Alex Riesen <raa.lkml@xxxxxxxxx> wrote: > > On Thu, Jan 6, 2011 at 18:49, Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> wrote: > >> > >> My fear is that some machines have a dependency between the backlight > >> and panel power status. The patch in question changed the timing between > >> turning on the panel and adjusting the backlight which would be restore > >> with: > >> > >> diff --git a/drivers/gpu/drm/i915/intel_lvds.c b/drivers/gpu/drm/i915/intel_lvds.c > >> index aa23070..0b40b4f 100644 > >> --- a/drivers/gpu/drm/i915/intel_lvds.c > >> +++ b/drivers/gpu/drm/i915/intel_lvds.c > >> @@ -106,6 +106,12 @@ static void intel_lvds_enable(struct intel_lvds *intel_lvds) > >> ?? ?? ?? ??I915_WRITE(ctl_reg, I915_READ(ctl_reg) | POWER_TARGET_ON); > >> ?? ?? ?? ??POSTING_READ(lvds_reg); > >> > >> + ?? ?? ?? { > >> + ?? ?? ?? ?? ?? ?? ?? u32 reg = HAS_PCH_SPLIT(dev) ? PCH_PP_STATUS : PPS_STATUS; > ... > > FWIW it does not compile: > > ??CC ?? ?? ??drivers/gpu/drm/i915/intel_lvds.o > > drivers/gpu/drm/i915/intel_lvds.c: In function ???intel_lvds_enable???: > > drivers/gpu/drm/i915/intel_lvds.c:110: error: ???PPS_STATUS??? undeclared > > Ah, I see. Should be PP_STATUS. Whatever. It does not help. The backlight > stays off. It didn't help in my case either -- Michal Hocko L3 team SUSE LINUX s.r.o. Lihovarska 1060/12 190 00 Praha 9 Czech Republic _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel