On Thu, Jan 6, 2011 at 21:55, Alex Riesen <raa.lkml@xxxxxxxxx> wrote:
> On Thu, Jan 6, 2011 at 18:49, Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> wrote:
>>
>> My fear is that some machines have a dependency between the backlight
>> and panel power status. The patch in question changed the timing between
>> turning on the panel and adjusting the backlight which would be restore
>> with:
>>
>> diff --git a/drivers/gpu/drm/i915/intel_lvds.c b/drivers/gpu/drm/i915/intel_lvds.c
>> index aa23070..0b40b4f 100644
>> --- a/drivers/gpu/drm/i915/intel_lvds.c
>> +++ b/drivers/gpu/drm/i915/intel_lvds.c
>> @@ -106,6 +106,12 @@ static void intel_lvds_enable(struct intel_lvds *intel_lvds)
>> Â Â Â ÂI915_WRITE(ctl_reg, I915_READ(ctl_reg) | POWER_TARGET_ON);
>> Â Â Â ÂPOSTING_READ(lvds_reg);
>>
>> + Â Â Â {
>> + Â Â Â Â Â Â Â u32 reg = HAS_PCH_SPLIT(dev) ? PCH_PP_STATUS : PPS_STATUS;
...
> FWIW it does not compile:
> ÂCC Â Â Âdrivers/gpu/drm/i915/intel_lvds.o
> drivers/gpu/drm/i915/intel_lvds.c: In function âintel_lvds_enableâ:
> drivers/gpu/drm/i915/intel_lvds.c:110: error: âPPS_STATUSâ undeclared
Ah, I see. Should be PP_STATUS. Whatever. It does not help. The backlight
stays off.
P.S. Probably unrelated, but I just noticed that the backlight never goes
off when closing the lid. Am I supposed to hook up on the corresponding
input event and put the panel in standby? It used to work all by itself,
I think...
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel
