Re: [PATCH] drm/radeon/kms: fix r600 vbo size computation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Aug 25, 2010 at 4:30 PM, Jerome Glisse <jglisse@xxxxxxxxxx> wrote:
> size given in resource is the exact size (not size - 1)
>

NAK, the vtx resource size is size minus 1.  See the accel code in the
ddx and the code in r600 driver in mesa.

Alex

> Signed-off-by: Jerome Glisse <jglisse@xxxxxxxxxx>
> ---
>  drivers/gpu/drm/radeon/r600_cs.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/r600_cs.c b/drivers/gpu/drm/radeon/r600_cs.c
> index d886494..487a765 100644
> --- a/drivers/gpu/drm/radeon/r600_cs.c
> +++ b/drivers/gpu/drm/radeon/r600_cs.c
> @@ -1401,7 +1401,7 @@ static int r600_packet3_check(struct radeon_cs_parser *p,
>                                        return -EINVAL;
>                                }
>                                offset = radeon_get_ib_value(p, idx+1+(i*7)+0);
> -                               size = radeon_get_ib_value(p, idx+1+(i*7)+1) + 1;
> +                               size = radeon_get_ib_value(p, idx+1+(i*7)+1);
>                                if (p->rdev && (size + offset) > radeon_bo_size(reloc->robj)) {
>                                        /* force size to size of the buffer */
>                                        dev_warn(p->dev, "vbo resource seems too big (%d) for the bo (%ld)\n",
> --
> 1.7.0.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@xxxxxxxxxxxxxxxxxxxxx
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
>
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel



[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux