ttm use pages don't need to populate?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



ttm_tt_set_user has "ttm->state = tt_unbound" which will cause the
following ttm_tt_populate return directly because of bellow check:
        if (ttm->state != tt_unpopulated)
                return 0;

Does it mean we don't need to populate user pages?  Here is the patch
if it is not the case

Thanks
Austin

>From 91ca6f8a5bb84a9375033d7df1cf7c0d1568e6ce Mon Sep 17 00:00:00 2001
From: Austin Yuan <shengquan.yuan@xxxxxxxxx>
Date: Tue, 29 Jun 2010 14:15:34 +0800
Subject: [PATCH] TTM: fix the issue that user buffers are not
populuated due to the wrong state

Signed-off-by: Austin Yuan <shengquan.yuan@xxxxxxxxx>
Signed-off-by: Elaine Wang <elaine.wang@xxxxxxxxx>
---
 drivers/gpu/drm/ttm/ttm_tt.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/gpu/drm/ttm/ttm_tt.c b/drivers/gpu/drm/ttm/ttm_tt.c
index a7bab87..4ea44c2 100644
--- a/drivers/gpu/drm/ttm/ttm_tt.c
+++ b/drivers/gpu/drm/ttm/ttm_tt.c
@@ -367,7 +367,7 @@ int ttm_tt_set_user(struct ttm_tt *ttm,

        ttm->tsk = tsk;
        ttm->start = start;
-       ttm->state = tt_unbound;
+       ttm->state = tt_unpopulated;

        return 0;
 }
--
1.6.0.4
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel


[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux