Re: [PATCH] drm/radeon/kms: add support for internal thermal sensors (v2)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jun  1, 2010 at 18:52:30 -0400, Alex Deucher wrote:

> diff --git a/drivers/gpu/drm/radeon/Kconfig b/drivers/gpu/drm/radeon/Kconfig
> index 80c5b3e..2e3896d 100644
> --- a/drivers/gpu/drm/radeon/Kconfig
> +++ b/drivers/gpu/drm/radeon/Kconfig
> @@ -2,6 +2,7 @@ config DRM_RADEON_KMS
>  	bool "Enable modesetting on radeon by default - NEW DRIVER"
>  	depends on DRM_RADEON
>  	depends on POWER_SUPPLY
> +	depends on HWMON
>  	help
>  	  Choose this option if you want kernel modesetting enabled by default.
>  
Shouldn't these be under CONFIG_DRM_RADEON, with _KMS only changing the
default value of the modeset parameter?  Otherwise you could still try
to build the driver with _KMS off, and CONFIG_HWMON disabled (which I
assume is going to fail).

Cheers,
Julien
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel


[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux