On Tue, Jun 01, 2010 at 05:41:34PM -0400, Alex Deucher wrote: > On Tue, Jun 1, 2010 at 4:42 PM, Matthew Garrett <mjg59@xxxxxxxxxxxxx> wrote: > > sensor tools depend on it. If there's only one sensor per GPU > > "temp1_input" is correct, with a "name" attribute indicating which card > > provides it. Also, make sure that you're exporting in millidegrees > > rather than degrees. > > OK. Celsius I assume? Sorry, yes. > >> + /* where's the best place to put this? */ > >> + sysfs_create_group(&rdev->dev->kobj, &evergreen_hwmon_attrgroup); > > > > They should be under the hwmon device. > > Should this be a new device? I wasn't able to find a good example of > a hwmon driver that was part of another driver rather than a > standalone device. It's what you get back from hwmon_register_device. http://lists.freedesktop.org/archives/nouveau/2009-November/004087.html is how I did this for nouveau, although it's not merged. -- Matthew Garrett | mjg59@xxxxxxxxxxxxx _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel