On Tue, Jun 1, 2010 at 4:42 PM, Matthew Garrett <mjg59@xxxxxxxxxxxxx> wrote: > On Tue, Jun 01, 2010 at 04:31:41PM -0400, Alex Deucher wrote: >> rv6xx/rv7xx/evergreen families supported; older asics did >> not have an internal thermal sensor. Exposed via sysfs >> gpu_temp attribute. > > This really should be done via the standard hwmon naming - some of the > sensor tools depend on it. If there's only one sensor per GPU > "temp1_input" is correct, with a "name" attribute indicating which card > provides it. Also, make sure that you're exporting in millidegrees > rather than degrees. OK. Celsius I assume? > >> Note also, that most laptops use an oem specific ACPI solution for >> GPU thermal information rather than using the internal thermal >> sensor directly. > > Is there any mechanism for determining which ACPI thermal zone is > associated with the GPU, or is this something that's hardcoded into the > drivers? I'll see if I can find out. > >> + /* where's the best place to put this? */ >> + sysfs_create_group(&rdev->dev->kobj, &evergreen_hwmon_attrgroup); > > They should be under the hwmon device. Should this be a new device? I wasn't able to find a good example of a hwmon driver that was part of another driver rather than a standalone device. Thanks! Alex > > -- > Matthew Garrett | mjg59@xxxxxxxxxxxxx > _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
