https://bugs.freedesktop.org/show_bug.cgi?id=27901 --- Comment #11 from Conn Clark <conn.o.clark@xxxxxxxxx> 2010-05-21 09:32:33 PDT --- On Fri, May 21, 2010 at 12:48 AM, <bugzilla-daemon@xxxxxxxxxxxxxxx> wrote: > https://bugs.freedesktop.org/show_bug.cgi?id=27901 > > --- Comment #10 from Alain Perrot <alain.perrot@xxxxxxxxx> 2010-05-21 00:48:34 PDT --- >> Alain, >> >> Its a tough call on who's is the better solution. Yours uses one less >> temp reg and mine will allow for a couple of operations to be done in >> parallel in the future. I guess we both deserve a pat on the back and >> leave it to someone more experienced to make the call on which one to >> choose. >> >> Good job >> >> Conn > > You're probably right (and I known nothing about parallelization on GPUs). > > In any way, many thanks for your help. > > -- > Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email > ------- You are receiving this mail because: ------- > You are the assignee for the bug. > _______________________________________________ > dri-devel mailing list > dri-devel@xxxxxxxxxxxxxxxxxxxxx > http://lists.freedesktop.org/mailman/listinfo/dri-devel > Alain, For the current code I think your patch a tad better. It uses one less instruction. Short of benchmarking the two solutions I think yours is the one that should go in. Would you please submit a patch that includes the assemble_SCS function as well. After you submit it with that change and a notice that you have singed off on it. I'll nominate it over my own to go in. Conn -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel