On Wed, May 12, 2010 at 5:57 AM, Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> wrote: > On Tue, 11 May 2010 12:10:01 -0700, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote: >> On Tue, 11 May 2010 19:52:31 +0100 >> Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> wrote: >> >> > On Tue, 11 May 2010 11:35:55 -0400, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote: >> > > No, io_mapping_map_atomic_wc() cannot be used from [soft]irq context: >> > > it hardwires use of KM_USER0. I suggest that io_mapping_create_wc(), >> > > io_mapping_map_atomic_wc() etc be changed so that the caller passes in the >> > > KM_foo kmap slot index. >> > >> > Argh, sorry for the noise, read the mail in the wrong order. Thanks for >> > the review. It would be sensible to go with your simpler patch whilst >> > io_mapping_map_atomic_wc() is improved. >> >> OK. I'll be sending a bunch of fixes Linuswards in an hour or two. >> Should I include this? > > Yes. > > Acked-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> > I'm not sure pushing this in at this point is a good idea, if I'm reading it correctly we've no idea what KM_IRQ is being used for, and this codepath is called from non-irq contexts just as much as irq contexts. I'd rather we just backout the hangcheck stuff touching copies at all at this point, and try again doing it properly with a slow work or something for later. Dave. _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
