> On 30-05-24, 11:11, Jia Jie Ho wrote: > > > + > > +struct dw_axi_peripheral_config { > > +#define DWAXIDMAC_STARFIVE_SM_ALGO BIT(0) > > what does this quirk mean? > > > + u32 quirks; > > Can you explain why you need this to be exposed. I would prefer we use > existing interfaces and not define a new one... > Hi Vinod, Thanks for reviewing this. This is a dedicated dma controller for the crypto engine. I am adding this quirk to: 1. Select the src and dest AXI master for transfers between mem and dev. Driver currently only uses AXI0 for both. 2. Workaround a hardware limitation on the crypto engine to transfer data > 256B by incrementing the peripheral FIFO offset. What is the recommended way to handle such cases besides using peripheral_config in dma_slave_config? Best regards, Jia Jie