Le 27/05/24 - 20:32, Markus Elfring a écrit : > > The current interrupt handler in xdma.c was using xdma->stop_request > > before locking the vchan lock. > > 1. Will an additional imperative wording become helpful here? > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10-rc1#n94 > > 2. How do you think about to use the summary phrase “Fix data synchronisation in xdma_channel_isr()”? I changed the commit message and summary in the v2. > 3. Will development interests grow for the usage of a statement like “guard(spin)(&xchan->vchan.lock);”? > https://elixir.bootlin.com/linux/v6.10-rc1/source/include/linux/cleanup.h#L124 I don't feel comfortable switching `guard` as the rest of the driver is not using it yet. Since this is a fix, I prefer to maintain consistency with the style of the rest of the driver. Thanks, Louis Chauvet > > Regards, > Markus > -- Louis Chauvet, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
