Re: [PATCH 4/7] dmaengine: ptdma: Extend ptdma to support multi-channel and version

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Basavaraj,

kernel test robot noticed the following build warnings:

[auto build test WARNING on vkoul-dmaengine/next]
[also build test WARNING on linus/master v6.9-rc7 next-20240510]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Basavaraj-Natikar/dmaengine-Move-AMD-DMA-driver-to-separate-directory/20240510-162221
base:   https://git.kernel.org/pub/scm/linux/kernel/git/vkoul/dmaengine.git next
patch link:    https://lore.kernel.org/r/20240510082053.875923-5-Basavaraj.Natikar%40amd.com
patch subject: [PATCH 4/7] dmaengine: ptdma: Extend ptdma to support multi-channel and version
config: x86_64-randconfig-122-20240511 (https://download.01.org/0day-ci/archive/20240511/202405111809.dOmIUtt3-lkp@xxxxxxxxx/config)
compiler: gcc-11 (Ubuntu 11.4.0-4ubuntu1) 11.4.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240511/202405111809.dOmIUtt3-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202405111809.dOmIUtt3-lkp@xxxxxxxxx/

All warnings (new ones prefixed by >>):

   drivers/dma/amd/ptdma/ptdma-dmaengine.c: In function 'pt_create_desc':
>> drivers/dma/amd/ptdma/ptdma-dmaengine.c:208:30: warning: variable 'cmd_q' set but not used [-Wunused-but-set-variable]
     208 |         struct pt_cmd_queue *cmd_q;
         |                              ^~~~~


vim +/cmd_q +208 drivers/dma/amd/ptdma/ptdma-dmaengine.c

   197	
   198	static struct pt_dma_desc *pt_create_desc(struct dma_chan *dma_chan,
   199						  dma_addr_t dst,
   200						  dma_addr_t src,
   201						  unsigned int len,
   202						  unsigned long flags)
   203	{
   204		struct pt_dma_chan *chan = to_pt_chan(dma_chan);
   205		struct pt_passthru_engine *pt_engine;
   206		struct pt_device *pt = chan->pt;
   207		struct ae4_cmd_queue *ae4cmd_q;
 > 208		struct pt_cmd_queue *cmd_q;
   209		struct pt_dma_desc *desc;
   210		struct ae4_device *ae4;
   211		struct pt_cmd *pt_cmd;
   212	
   213		desc = pt_alloc_dma_desc(chan, flags);
   214		if (!desc)
   215			return NULL;
   216	
   217		pt_cmd = &desc->pt_cmd;
   218		pt_cmd->pt = pt;
   219		pt_engine = &pt_cmd->passthru;
   220		pt_cmd->engine = PT_ENGINE_PASSTHRU;
   221		pt_engine->src_dma = src;
   222		pt_engine->dst_dma = dst;
   223		pt_engine->src_len = len;
   224		pt_cmd->pt_cmd_callback = pt_cmd_callback;
   225		pt_cmd->data = desc;
   226	
   227		desc->len = len;
   228	
   229		if (pt->ver == AE4_DMA_VERSION) {
   230			ae4 = container_of(pt, struct ae4_device, pt);
   231			ae4cmd_q = &ae4->ae4cmd_q[chan->id];
   232			cmd_q = &ae4cmd_q->cmd_q;
   233			mutex_lock(&ae4cmd_q->cmd_lock);
   234			list_add_tail(&pt_cmd->entry, &ae4cmd_q->cmd);
   235			mutex_unlock(&ae4cmd_q->cmd_lock);
   236		}
   237	
   238		return desc;
   239	}
   240	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki




[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux PCI]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux