On Tue, Mar 26, 2024 at 01:14:12PM +0100, Krzysztof Kozlowski wrote: > On 26/03/2024 13:06, Inochi Amaoto wrote: > e. > >>>> + regmap_set_bits(dmamux->regmap, > >>>> + DMAMUX_CH_REG(chid), > >>>> + DMAMUX_CH_SET(chid, devid)); > >>>> + > >>>> + regmap_update_bits(dmamux->regmap, CV1800_SDMA_DMA_INT_MUX, > >>>> + DMAMUX_INT_CH_MASK(chid, cpuid), > >>>> + DMAMUX_INT_CH_BIT(chid, cpuid)); > >>> > >>> I think this is. > >> > >> So where exactly? I don't see any define being used here. > >> CV1800_SDMA_DMA_INT_MUX is not in your header. DMAMUX_ is not in your > >> header. So what are you pointing? > >> > >> I don't understand this communication. Are you mocking me here or what? > >> It's waste of my time. > >> > > > > I apologize for my misunderstanding and your wasted time. I had > > previously thought that hardware constants is also binding. This > > leads to a weird communication between us. Since I agree and > > understand this file is not a binding, I will remove this file in > > the next version. Anyway, thanks for your kindly explanation. > > OK, no problem. When I asked where do you use header, it should make you > think... remove the #include from the driver and everything still > compiles, so obviously header is not being used. > > Best regards, > Krzysztof > Thanks, I will think and do this for the future patch. Regards, Inochi
