On Wednesday, January 31, 2024 6:18:57 PM CET Rob Herring wrote:
> On Sun, Jan 28, 2024 at 07:01:36PM +0100, Duje Mihanović wrote:
> > On Sunday, January 28, 2024 6:28:03 PM CET Conor Dooley wrote:
> > > That said, for properties that are only usable on some platforms, please
> > > define them at the top level and conditionally permit/constrain them.
> >
> > Could you please point me to how to do so if this if/then does not do it
> > properly?
>
> Negate the if and then:
>
> then:
> properties:
> asram: false
>
> There are lots of examples in the tree.
This works as expected, thanks.
> > > > +unevaluatedProperties: false
> > > > +
> > > > +examples:
> > > > + # Peripheral controller
> > > > + - |
> > > > + pdma0: dma-controller@d4000000 {
> > >
> > > The label is not needed here or below.
> > > In fact, I'd probably delete the second example as it shows nothing that
> > > the first one does not.
> >
> > I'd rather add the asram property in the second node (adding onto the
above
> > comment, I now see that it shouldn't have even passed dt_binding_check
> > because of the missing asram, but it did).
>
> It passed because 'required' is what checks for property presence and
> nowhere is asram required. It is missing a type definition which should
> have warned, but may not since it is under an 'if'.
I thought specifying minItems would have the same effect, but that turned out
not to be the case. Also, the 'if' did indeed suppress the missing type
warning.
Regards,
--
Duje
