> From: Jacob Pan <jacob.jun.pan@xxxxxxxxxxxxxxx> > Sent: Friday, April 28, 2023 1:50 AM > > > +static int dmar_domain_attach_device_pasid(struct dmar_domain *domain, > + struct intel_iommu *iommu, > + struct device *dev, ioasid_t pasid) > +{ > + int ret; > + > + /* PASID table is mandatory for a PCI device in scalable mode. */ > + if (!sm_supported(iommu) && dev_is_real_dma_subdevice(dev)) > + return -EOPNOTSUPP; "&&" should be "||"