On Tue, Feb 14, 2023 at 1:18 PM Martin Povišer <povik+lin@xxxxxxxxxxx> wrote: > > > > On 14. 2. 2023, at 17:12, Rob Herring <robh@xxxxxxxxxx> wrote: > > On Tue, 14 Feb 2023 15:10:53 +0100, Martin Povišer wrote: > >> Describe the SIO coprocessor which serves as pretend DMA controller on > >> recent Apple platforms. > >> > >> Signed-off-by: Martin Povišer <povik+lin@xxxxxxxxxxx> > >> --- > >> > >> Since the schema mentions a loader preparing the binding appropriately, > >> here's a PR with the relevant (WIP) loader code, if anyone wants to look: > >> https://github.com/AsahiLinux/m1n1/pull/286 > >> > >> .../devicetree/bindings/dma/apple,sio.yaml | 129 ++++++++++++++++++ > >> 1 file changed, 129 insertions(+) > >> create mode 100644 Documentation/devicetree/bindings/dma/apple,sio.yaml > >> > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > > > yamllint warnings/errors: > > > > dtschema/dtc warnings/errors: > > Documentation/devicetree/bindings/dma/apple,sio.example.dts:24.35-27.11: Warning (node_name_vs_property_name): /example-0/interrupt-controller: node name and property name conflict > > I saw the warning, but since I had copied that part of the example from > apple,admac.yaml I didn’t make much of it. Now that I look at it again, > the example in apple,admac doesn’t raise the same warning, how come? > > This is just a curiosity since we don’t need the aic node in the example > anyway (unlike in apple,admac where it’s needed because of empty entries > in interrupts-extended). 'interrupts-extended' is why. If the example just has 'interrupts', then a fake parent is constructed. It's pretty hacky, but necessary to parse the interrupts later on for validation. Rob
